[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

Wed Jan 29 14:08:35 PST 2020

ychen added a comment.

In D67847#1847757 <https://reviews.llvm.org/D67847#1847757>, @rnk wrote:

> If we can reland this patch, it should fix this new clang bug:
>  https://bugs.llvm.org/show_bug.cgi?id=44705
>
> This was the list of failures you noted on the commit:
>
> In rG647c3f4e47de8a850ffcaa897db68702d8d2459a#885042 <https://reviews.llvm.org/rG647c3f4e47de8a850ffcaa897db68702d8d2459a#885042>, @ychen wrote:
>
> > This is going deeper...
> >
> > - Host compiler crash (looks like ppc64be-specific) http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23016 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/43016 http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/34286
> > - clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp becomes pass/fail randomly
> > - test timeout http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/2170/steps/test-openmp/logs/stdio
> > - ThinLTO test failures on Redhat (passes on my ubuntu 18.04) http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/592
> >
> >   Will investigate.
>
>
> The ppc64be stuff seems like only someone with hardware will be able to debug it.
>  For `clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp`, you are saying you can reproduce that locally?
>  The timeout seems like it could be flakiness or something unrelated.
>  The thinlto failures... I'm not sure either, but again it's PPC64, so it could be flakiness.
>
> It seems like it would be best to alert the owners of those bots and reland and get new results, assuming things pass on less exotic bot configurations.

`p3-2a.cpp` random failure is fixed.
Thinlto / PPC issues are OOM related. PPC admin suggested recommit.

I've confirmed locally that failures on sanitier_windows are real (Patches are below), but I have no clue about how they are related.
D73329 <https://reviews.llvm.org/D73329>
D73327 <https://reviews.llvm.org/D73327>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67847/new/

https://reviews.llvm.org/D67847