[PATCH] D73655: [MLIR] Break cyclic dependency between MLIRPass and MLIRAnalysis

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.

LGTM, thanks!

But I'd like to have River's review here first.



================
Comment at: mlir/lib/Analysis/CMakeLists.txt:54
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
+  )
+target_link_libraries(MLIRVerifier MLIRAffineOps MLIRLoopOps MLIRVectorOps)
----------------
I have a local patch prototyping this as well, but I split this in two libraries because it seemed a bit strange to me that using "Dominance" would require me to ask for linking to libVerifier (I'm not opposed this though).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73655/new/

https://reviews.llvm.org/D73655