[PATCH] D73653: [MLIR] Fixes for shared library dependencies.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 21:55:17 PST 2020


mehdi_amini added a comment.

> A separate issue is that in cmake, dependencies between static libraries
>  are automatically included in dependencies. In the above example, if MLIBlib1
>  depends on MLIRlib2, then it is sufficient to have only MLIRlib1 in the
>  target_link_libraries. When compiling with shared libraries, it is necessary
>  to have both MLIRlib1 and MLIRlib2 specified.

I believe this is only an issue if the target is directly using symbols from MLIRlib2 though.
If it only needs symbols from MLIRLib1 then this shouldn't be an issue right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73653/new/

https://reviews.llvm.org/D73653





More information about the llvm-commits mailing list