[PATCH] D73523: [CMake][compiler-rt] Replace Windows backslashes with CMake ones

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:251-252
       list(GET CONFIG_OUTPUT 1 LIBLIST)
-      set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library")
-      set(LLVM_XRAY_LIBLIST ${LIBLIST} CACHE STRING "Library list for LLVMXRay")
+      string(REPLACE "\\" "/" LDFLAGS ${LDFLAGS})
+      string(REPLACE "\\" "/" LIBLIST ${LIBLIST})
+      set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library" FORCE)
----------------
smeenai wrote:
> Does `file(TO_CMAKE_PATH)` work for this?
I tried it and it seems to work.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:253
+      string(REPLACE "\\" "/" LIBLIST ${LIBLIST})
+      set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library" FORCE)
+      set(LLVM_XRAY_LIBLIST ${LIBLIST} CACHE STRING "Library list for LLVMXRay" FORCE)
----------------
smeenai wrote:
> Why the addition of `FORCE`?
Leftover from debugging.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73523/new/

https://reviews.llvm.org/D73523