[PATCH] D73669: [ConstantFold][SVE] Do not iterate on scalable vector for ConstantFoldSelectInstruction.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 18:04:06 PST 2020
efriedma added a comment.
It's impossible for a ConstantDataVector or a ConstantVector to be scalable at the moment. And I don't expect that will ever change: there isn't any incentive to make any new constant representation use those types, as opposed to making a new subclass of Constant. Given that, I don't think it's worth adding guards to code that's already explicitly looking for a ConstantVector/ConstantDataVector.
Test change looks fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73669/new/
https://reviews.llvm.org/D73669
More information about the llvm-commits
mailing list