[PATCH] D73656: [mlir][Linalg] Add a Linalg DRR test to go from matmul to vectors

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 17:27:09 PST 2020


aartbik added inline comments.


================
Comment at: mlir/test/lib/Transforms/TestLinalgMatmulToVector.cpp:38
+    // after AffineApplyOp canonicalization to get fully static shapes.
+    // Unfortunately bumping up the priority of AffineApplyOp canonicalization
+    // does not help and making ViewOp canonicalization know about AffineApplyOp
----------------
would it help to have two passes of greedily applying patterns, each with their own set, or do we have interaction between the two sets?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73656/new/

https://reviews.llvm.org/D73656





More information about the llvm-commits mailing list