[PATCH] D73597: [LTO] Add optimization remarks for removed functions

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 15:48:15 PST 2020


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/LTO/LTO.cpp:967
+
+  // Ensure we don't have inconsistently split LTO units with type tests.
+  if (Error Err = checkPartiallySplit())
----------------
xazax.hun wrote:
> tejohnson wrote:
> > Can you add a FIXME here noting that this is checking both Regular and Thin LTO and should be split into two, one checking Regular here and the other checking the ThinLTO index in runThinLTO?
> > 
> > This does work since we always go through this path, but logically it would make more sense to do the ThinLTO checking in runThinLTO. Unfortunately, the regular LTO checking this is doing must be after linkRegularLTO.
> Let me know if you prefer to reword this. I am not a native speaker and not familiar with the nomenclature of LLVM.  
It looks fine, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73597/new/

https://reviews.llvm.org/D73597





More information about the llvm-commits mailing list