[PATCH] D73329: [libFuzzer] communicate through pipe to subprocess for MinimizeCrashInput

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a reviewer: vitalybuka.
kcc added a comment.

It looks like this patch has at least two independent changes. 
Please prefer to send two+ individual changes next time. (even if the patches are tiny).

Vitaly, please review



================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:36
 #pragma comment(linker, "/include:__libfuzzer_is_present")
+#define POPEN _popen
+#define PCLOSE _pclose
----------------
any chance to not have any macros? 


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:327
+    char TmpBuffer[128];
+    while (fgets(TmpBuffer, 128, Pipe))
+      CmdOutput->append(TmpBuffer);
----------------
replace 128 with sizeof(TmpBuffer)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73329/new/

https://reviews.llvm.org/D73329