[PATCH] D73524: [CMake][DFSan] Don't use cat as it's not available on Windows
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 15:38:41 PST 2020
phosek added a comment.
In D73524#1845807 <https://reviews.llvm.org/D73524#1845807>, @efriedma wrote:
> http://llvm.org/docs/GettingStarted.html#software currently says exactly the opposite of what this patch is doing: cat is required to build LLVM, python is optional. Is that out of date?
Does that apply to runtimes as well? The way I ran into this was building a complete Clang toolchain on Windows (just build, not running tests) without having GnuWin32 installed, and this was the only issue. Looking around the tree, I noticed that libc++ already uses this approach https://github.com/llvm/llvm-project/blob/master/libcxx/include/CMakeLists.txt#L186 hence following the same pattern here, but I'm happy to use a different approach if that's preferred.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73524/new/
https://reviews.llvm.org/D73524
More information about the llvm-commits
mailing list