[PATCH] D68063: Propeller: LLVM support for basic block sections

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:262
+  /// corresponding to -fbasicblock-sections.
+  llvm::BasicBlockSection::SectionMode getBasicBlockSections() const {
+    return Options.BasicBlockSections;
----------------
nit: naming consistency: getBasicBlockSections -->getBBSections


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:268
+  /// basic block sections must be generated.
+  bool isFunctionInBasicBlockSectionsList(const StringRef &name) const {
+    return Options.BasicBlockSectionsList.find(name) !=
----------------
isFunctionBBSectionsList.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:275
+  /// emitted in a unique section.
+  SmallSet<unsigned, 4> getBasicBlockSectionsSet(const StringRef &name) const {
+    return Options.BasicBlockSectionsList.lookup(name);
----------------
getBBSectionSet


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063