[PATCH] D73550: Prevent building with MSVC 14.24

Wed Jan 29 14:53:40 PST 2020

mehdi_amini added a comment.

In D73550#1848076 <https://reviews.llvm.org/D73550#1848076>, @aganea wrote:

> In D73550#1848010 <https://reviews.llvm.org/D73550#1848010>, @mehdi_amini wrote:
>
> > I have concern with this patch: this is a big hammer that blocks building *anything* using LLVM even if it does not involve any of the code path that is problematic.
>
>
> How can you tell which parts of the code are affected by this miscompilation? I've seen occasionally crashes in opt which only occur for this version of MSVC. I fear that people would lose time investigating indirect bugs caused by this.

My project tests aren't broken :)

People would have to explicitly disable the CMake check so they would take it upon themselves to investigate bugs.

>> I would rather see this implemented as a CMake check and a flag that can override/disable the check.
> 
> Do you see this as an issue for end-users/consumers of LLVM? Or just for LLVM developers? One can simply disable this check locally, given that 16.5 will be released soon; or use clang-cl 9.0.1.

I know one current issue for a consumer of LLVM (but this is just one example):  the TensorFlow CI is broken on Windows (it is using MLIR for its TensorFlow lite converter which is pulling the LLVM Support library (and nothing else I suspect).

Of course this affects *every* consumer of MLIR, but I haven't seen an evidence of a problem there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73550/new/

https://reviews.llvm.org/D73550