[PATCH] D73471: Add tanh lowering from Standard dialect to NVVM and ROCDL.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

These two tests are failing on Windows like so:

  ##[error]mlir\test\Conversion\GPUToROCDL\gpu-to-rocdl.mlir(87,12): Error GDC2C77F0: CHECK: expected string not found in input
       1>E:\agent\_work\4\s\mlir\test\Conversion\GPUToROCDL\gpu-to-rocdl.mlir(87,12): error GDC2C77F0: CHECK: expected string not found in input [e:\agent\_work\4\b\check-all.vcxproj]
           
            // CHECK: llvm.func @_ocml_tanh_f32(!llvm.float) -> !llvm.float
           
                      ^
           
           <stdin>:66:2: note: scanning from here
           
            llvm.return
           
            ^
           
           <stdin>:73:2: note: possible intended match here
           
            llvm.func @tanhf(!llvm.float) -> !llvm.float
           
            ^

It looks like the fix is fairly straightforward at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73471/new/

https://reviews.llvm.org/D73471