[PATCH] D73411: [InstCombine] Process newly inserted instructions in the correct order

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM



================
Comment at: llvm/include/llvm/Transforms/InstCombine/InstCombineWorklist.h:30
+  /// These instructions will be added in reverse order after the current
+  /// combined has finished. This means that these instructions will be visited
+  /// in the order they have been added.
----------------
typo: combined -> combine


================
Comment at: llvm/include/llvm/Transforms/InstCombine/InstCombineWorklist.h:59
 
+  void AddDeferred(Instruction *I) {
+    if (Deferred.insert(I))
----------------
Could take this opportunity to correct all of the ill-formatted 'FunctionNames' to 'functionNames'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73411/new/

https://reviews.llvm.org/D73411