[PATCH] D73212: [NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 13:59:13 PST 2020


cameron.mcinally marked 2 inline comments as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:29
+def NotDestructive       : DestructiveInstTypeEnum<0>;
+def DestructiveOther     : DestructiveInstTypeEnum<1>;
+
----------------
sdesmalen wrote:
> nit: could this do with a comment on what DestructiveOther means? (something along the lines that it tells the instruction is destructive in its first source operand and can be movprfx'ed, but has no other special properties like commutativity or anything else)
Is this ok with you? If not, I'll update with the next patch. I'm about to change a bunch of this stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73212/new/

https://reviews.llvm.org/D73212





More information about the llvm-commits mailing list