[PATCH] D73011: [opt viewer] Python compat - decode/encode string
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 12:26:05 PST 2020
serge-sans-paille accepted this revision.
serge-sans-paille added a comment.
This revision is now accepted and ready to land.
> @serge-sans-paille io.open is supported since 2.6 https://docs.python.org/2/library/io.html#module-interface. I did test that the patch works for both 2.7 and >3. I saw some failures with the Unicode problem without this change.
Good lord - you're absolutely right!
The discussion diverged because of the python3 shebang, but the actual diff is portable. LGTM then :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73011/new/
https://reviews.llvm.org/D73011
More information about the llvm-commits
mailing list