[PATCH] D72822: [mlir] Replace AbstractOperation::classof with a ClassID instance.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 12:17:05 PST 2020
rriddle added a comment.
> So it seems it still might be the case that pointer can differ. D72584 <https://reviews.llvm.org/D72584> fixed this by falling back more often to the string comparison.
You are going to run into a much bigger problem given that this depends on ClassOf, which is a static `typeid` that is used pervasively across the entire code base. Making that work with shared libraries is likely the most important(difficult?) task item.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72822/new/
https://reviews.llvm.org/D72822
More information about the llvm-commits
mailing list