[PATCH] D73554: [AIX] Don't use a zero fill with a second parameter
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 11:58:42 PST 2020
jasonliu added inline comments.
================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:182
+ /// other than zero. Defaults to true.
+ bool ZeroDirectiveSupportsNonZeroValue = true;
+
----------------
Have we consider rename the ZeroDirective to FillDirective and fix the comments there?
Since this ZeroDirective did not convey what it really means.
And this query is more like "FillDirectiveSupportsNonZeroFill".
================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1116
+ "fill.");
+ for (int i = 0; i < cast<MCConstantExpr>(NumBytes).getValue(); i++) {
+ OS << "\t.byte\t";
----------------
Make it a const variable so that we don't need to make a function call every time in the loop?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73554/new/
https://reviews.llvm.org/D73554
More information about the llvm-commits
mailing list