[PATCH] D73652: Defer composing subregisters with DW_OP_piece

[Adrian Prantl via Phabricator via llvm-commits]

aprantl created this revision.
aprantl added reviewers: bjope, djtodoro, vsk, probinson.
aprantl added a project: debug-info.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
aprantl added a child revision: D73283: Handle complex DWARF expressions in combination with "complex" registers.
aprantl updated this revision to Diff 241235.
aprantl added a comment.

Factored out the NFC bits.


This NFC(ish*) patch defers the decision on which DW_OP_pieces to emit when composing a superregister out of subregisters to addMachineRegExpression. This is in preparation of https://reviews.llvm.org/D73283.

This patch also removes the now redundant `MaxSize` parameter.

*) One could construct a target in which a superregister could not be fully covered by subregsiters, in which case this code gives up instead of emitting an undefined DW_OP_piece.


https://reviews.llvm.org/D73652

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  llvm/test/DebugInfo/MIR/ARM/split-superreg-complex.mir
  llvm/test/DebugInfo/MIR/ARM/subregister-complex-expression.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73652.241235.patch
Type: text/x-patch
Size: 10554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200129/1ce68ad2/attachment.bin>