[PATCH] D73650: [GlobalISel][IRTranslator] Follow convention and put constant offset of getelementptr arithmetic on RHS.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 11:21:46 PST 2020


aemerson created this revision.
aemerson added reviewers: paquette, arsenm.
aemerson added a project: LLVM.
Herald added subscribers: kerbowa, Petar.Avramovic, volkan, jfb, hiraditya, rovka, nhaehnle, wdng, jvesely.

We were needlessly putting known constant values on the LHS of a G_MUL, which is suboptimal.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73650

Files:
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator-gep.ll
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator-switch.ll
  llvm/test/CodeGen/AArch64/GlobalISel/translate-gep.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-getelementptr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/lds-relocs.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.atomic.dec.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.atomic.inc.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.is.private.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.is.shared.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.update.dpp.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/mubuf-global.ll
  llvm/test/CodeGen/X86/GlobalISel/add-ext.ll
  llvm/test/CodeGen/X86/GlobalISel/ptr-add.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73650.241234.patch
Type: text/x-patch
Size: 87827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200129/27c094b2/attachment.bin>


More information about the llvm-commits mailing list