[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1178
     uint8_t SymbolType = ELF::STT_NOTYPE;
+    int64_t SymbolIndex = getSymbolIndex(Obj, Symbol);
+
----------------
jasonliu wrote:
> const?
We are not using this SymbolIndex anywhere other than the emplace_back(), we don't really need this variable.
And also for consistency, we might want to consider calling getSymbolIndex() in every emplace_back that needs a symbol table index. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973