[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1187
+    if (Obj->isXCOFF())
+      SymbolType = getXCoffSymbolCsectSMC(Obj, Symbol);
+
----------------
Could we do a clean up here to make the code a little better?

if (Obj->isELF()) {
...
} else if (Mach0) {
...
} else if (Obj->isXCOFF()) {
...
}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973