[PATCH] D73639: [LLVM] Wrap extern TLS variable in getter Function

[Markus Böck via Phabricator via llvm-commits]

zero9178 marked 2 inline comments as done.
zero9178 added a comment.

In D73639#1847333 <https://reviews.llvm.org/D73639#1847333>, @russell.gallop wrote:

> > Additionally it allows Clang versions prior to 10 to compile current trunk.
>
> I have been using Clang prior to 10 to compile without this change. Do you mean with BUILD_SHARED_LIBS for this as well?


I believe this only occurs when using clang with MinGW as it needs to generate extra wrapper symbols that previously didn't have some needed comdat attributes



================
Comment at: llvm/lib/Support/TimeProfiler.cpp:34
+// Per Thread instance
+LLVM_THREAD_LOCAL llvm::TimeTraceProfiler *TimeTraceProfilerInstance = nullptr;
 } // namespace
----------------
mstorsjo wrote:
> You can remove the `llvm::` prefix, as this is within an anonymous namespace, like ThreadTimeTraceProfilerInstances.
I don't fully understand. TimeTraceProfiler is in the namespace llvm so I'd get an unknown typename if I were to remove it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73639/new/

https://reviews.llvm.org/D73639