[PATCH] D73597: [LTO] Add optimization remarks for removed functions

[Gábor Horváth via Phabricator via llvm-commits]

xazax.hun marked an inline comment as done.
xazax.hun added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:790
+        auto RemStr =
+            formatv("Function not added to combined module: {0}", F->getName());
+        ORE.emit(OptimizationRemark(DEBUG_TYPE, "deadfunction", F)
----------------
thegameg wrote:
> This is not the usual way we add strings with arguments to remarks. Please use `<< "STR: " << ore::NV("Function", F)`.
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73597/new/

https://reviews.llvm.org/D73597