[PATCH] D73648: Don't mark MIPS TRAP as isTerminator

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
arichardson added reviewers: atanasyan, jgalenson.
Herald added subscribers: llvm-commits, jrtc27, hiraditya, kristof.beyls, sdardis.
Herald added a project: LLVM.

This was causing machine verifier errors when compiling libunwind.
I am not 100% certain the flags are correct, I simply copied the flags
that AArch64 and X86 use.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73648

Files:
  llvm/lib/Target/Mips/MipsInstrInfo.td
  llvm/test/CodeGen/Mips/call-after-trap.ll


Index: llvm/test/CodeGen/Mips/call-after-trap.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/Mips/call-after-trap.ll
@@ -0,0 +1,33 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; Previously a call to @llvm.trap() with following code would cause machine
+; verifier issues on MIPS (as TRAP was marked as being a terminator).
+; This compiles fine on other architectures, so check we do the same for MIPS.
+; RUN: llc -mtriple=mips64-unknown-freebsd -relocation-model=pic -verify-machineinstrs %s -o - | FileCheck %s
+
+
+declare void @llvm.trap() #0
+declare void @widget() #1
+define hidden void @eggs() #1 {
+; CHECK-LABEL: eggs:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    daddiu $sp, $sp, -16
+; CHECK-NEXT:    sd $ra, 8($sp) # 8-byte Folded Spill
+; CHECK-NEXT:    sd $gp, 0($sp) # 8-byte Folded Spill
+; CHECK-NEXT:    lui $1, %hi(%neg(%gp_rel(eggs)))
+; CHECK-NEXT:    daddu $1, $1, $25
+; CHECK-NEXT:    daddiu $gp, $1, %lo(%neg(%gp_rel(eggs)))
+; CHECK-NEXT:    break
+; CHECK-NEXT:    ld $25, %call16(widget)($gp)
+; CHECK-NEXT:    .reloc .Ltmp0, R_MIPS_JALR, widget
+; CHECK-NEXT:  .Ltmp0:
+; CHECK-NEXT:    jalr $25
+; CHECK-NEXT:    nop
+entry:
+  call void @llvm.trap()
+  call void @widget() #2
+  unreachable
+}
+
+attributes #0 = { cold noreturn nounwind }
+attributes #1 = { nounwind "use-soft-float"="true" }
+attributes #2 = { noreturn }
Index: llvm/lib/Target/Mips/MipsInstrInfo.td
===================================================================
--- llvm/lib/Target/Mips/MipsInstrInfo.td
+++ llvm/lib/Target/Mips/MipsInstrInfo.td
@@ -1871,10 +1871,11 @@
 class TrapBase<Instruction RealInst>
   : PseudoSE<(outs), (ins), [(trap)], II_TRAP>,
     PseudoInstExpansion<(RealInst 0, 0)> {
-  let isBarrier = 1;
-  let isTerminator = 1;
+  let mayStore = 0;
+  let mayLoad = 0;
+  let hasSideEffects = 1;
+  let isTrap = 1;
   let isCodeGenOnly = 1;
-  let isCTI = 1;
 }
 
 //===----------------------------------------------------------------------===//


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73648.241217.patch
Type: text/x-patch
Size: 2079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200129/199a7351/attachment.bin>