[PATCH] D73574: Omit "Contents of" headers when -no-leading-headers is specified.

[Michael Trent via Phabricator via llvm-commits]

mtrent marked an inline comment as done.
mtrent added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/macho-cstring-dump.test:3
 RUN: llvm-objdump -m -section __TEXT,__cstring -no-leading-addr %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s -check-prefix=NO_ADDR
+RUN: llvm-objdump -m -section __TEXT,__cstring -no-leading-addr -no-leading-headers %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s -check-prefix=NO_ADDR_NO_HEADERS
 RUN: llvm-objdump -m -section __TEXT,__cstring -non-verbose %p/Inputs/hello.obj.macho-x86_64 | FileCheck %s -check-prefix=NON_VERBOSE
----------------
jhenderson wrote:
> As the two switches are separate, let's not specify them both. I think this test case can just specify no-leading-headers.
> 
> If you think the combination of them both is worth testing, do that in addition to the individual cases.
A reasonable point. I'll update the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73574/new/

https://reviews.llvm.org/D73574