[PATCH] D72027: [XCOFF][AIX] Support basic relocation type on AIX

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.

Other than minor nit, LGTM



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:706
+    Sec->FileOffsetToRelocations = RawPointer;
+    assert(Sec->RelocationCount <
+               (UINT32_MAX / XCOFF::RelocationSerializationSize32) &&
----------------
nit: shouldn't these exceeding 32-bit assertions be report_fatal_errors?  The user isn't going to get back a usable object file if this is the case.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp:50
+  // based on similar property of IsPCRel. So we will do the same here.
+  // TODO: More investigation on how assembler decide to set the sign
+  // bit, and we might want to match that.
----------------
nit: decides


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72027/new/

https://reviews.llvm.org/D72027