[PATCH] D73571: [MLIR] Add the sqrt operation to mlir.
Lubomir Litchev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 09:40:24 PST 2020
llitchev marked 3 inline comments as done.
llitchev added inline comments.
================
Comment at: mlir/docs/Dialects/Standard.md:606
+// Tensor element-wise square root value.
+%x = sqrt %y : tensor<4x?xf8>
+```
----------------
ftynse wrote:
> f8 isn't a valid type :)
Changed the type to f32.
================
Comment at: mlir/docs/Dialects/Standard.md:609
+
+The `sqrt` operation computes the square root. It takes one operand and
+returns one result of the same type. This type may be a float scalar type, a
----------------
ftynse wrote:
> This description should go into ODS. We have an open bug to fully autogenerate this doc from there.
Moved the description to the op def.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73571/new/
https://reviews.llvm.org/D73571
More information about the llvm-commits
mailing list