[PATCH] D73212: [NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType
    Sander de Smalen via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jan 29 08:16:35 PST 2020
    
    
  
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:29
+def NotDestructive       : DestructiveInstTypeEnum<0>;
+def DestructiveOther     : DestructiveInstTypeEnum<1>;
+
----------------
nit: could this do with a comment on what DestructiveOther means? (something along the lines that it tells the instruction is destructive in its first source operand and can be movprfx'ed, but has no other special properties like commutativity or anything else)
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73212/new/
https://reviews.llvm.org/D73212
    
    
More information about the llvm-commits
mailing list