[PATCH] D73595: [mlir][Linalg][doc] Add Design Document for the Linalg Dialect
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 08:07:35 PST 2020
rriddle added a comment.
In D73595#1846944 <https://reviews.llvm.org/D73595#1846944>, @nicolasvasilache wrote:
> @ftynse I fully agree hence my pushing back on the github comments.
If you had started submitting this incrementally, you wouldn't have this problem ;)
> @rriddle can we please move forward?
> I'll integrate the current review and then we can iterate like Alex suggests?
Is there a rush here? I have some strong concerns with the way this document is structured as-is, which are largely enumerated by Uday on the github commit:
> This file doesn't appear to be just the documentation or design doc of Linalg but also a rationale doc + past survey/experience + related work discussion + opinion + future thoughts > / side comments and some amount of vision. Writing these up is useful, but I think it's both misnamed and misplaced in the directory tree. For eg., other docs/Dialects/*.md file have > vastly different content.
What is the plan to resolve these?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73595/new/
https://reviews.llvm.org/D73595
More information about the llvm-commits
mailing list