[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 03:21:12 PST 2020
grimar added inline comments.
================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:167
+- Name: .rel.text
+ Type: SHT_REL
+ Info: .text
----------------
I think previously we agreed to check both SHT_REL and SHT_RELA here.
================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:180
+ Binding: STB_GLOBAL
\ No newline at end of file
----------------
You need to add a new line to fix "No newline at end of file" warning.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72992/new/
https://reviews.llvm.org/D72992
More information about the llvm-commits
mailing list