[PATCH] D73362: [mlir] EnumsGen: dissociate string form of integer enum from C++ symbol name

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

In D73362#1843343 <https://reviews.llvm.org/D73362#1843343>, @antiagainst wrote:

> I meant that instead of having both `I32EnumAttrCase` (taking two parameters) and `I32StrEnumAttrCase` (taking three parameters), what about just having `I32EnumAttrCase` and making it taking in `string cSym, int cVal, string strVal = cSym`? Similarly for other `*EnumAttrCase`s.


Great suggestion, thanks! Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73362/new/

https://reviews.llvm.org/D73362