[PATCH] D73400: AMDGPU/GlobalISel: Custom lower G_FEXP

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 01:47:55 PST 2020


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:525
 
-  // FIXME: fexp, flog2, flog10 needs to be custom lowered.
-  auto &FExp2Ops = getActionDefinitionsBuilder({G_FPOW, G_FEXP,
-                                                G_FEXP2, G_FLOG2});
+  // FIXME: fpow has a selection paattern that should move to custom lowering.
+  auto &Exp2Ops = getActionDefinitionsBuilder({G_FEXP2, G_FLOG2, G_FPOW});
----------------
Typo: pattern


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73400/new/

https://reviews.llvm.org/D73400





More information about the llvm-commits mailing list