[PATCH] D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().
    Alex Zinenko via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jan 29 00:50:09 PST 2020
    
    
  
ftynse accepted this revision.
ftynse added inline comments.
================
Comment at: mlir/include/mlir/IR/StandardTypes.h:393
 public:
+  // This is a builder type that keeps local references to arguments. Arguments
+  // that are passed into the builder must out-live the builder.
----------------
Nit: use `///` for class/function comments
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73296/new/
https://reviews.llvm.org/D73296
    
    
More information about the llvm-commits
mailing list