[PATCH] D73591: [NFC] Fix unused variable warning.

Nate Voorhies via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 17:10:55 PST 2020


ncv updated this revision to Diff 241027.
ncv added a comment.

Using isa<> rather than dyn_cast and discarding result.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73591/new/

https://reviews.llvm.org/D73591

Files:
  llvm/lib/Object/SymbolSize.cpp


Index: llvm/lib/Object/SymbolSize.cpp
===================================================================
--- llvm/lib/Object/SymbolSize.cpp
+++ llvm/lib/Object/SymbolSize.cpp
@@ -28,7 +28,7 @@
 static unsigned getSectionID(const ObjectFile &O, SectionRef Sec) {
   if (auto *M = dyn_cast<MachOObjectFile>(&O))
     return M->getSectionID(Sec);
-  if (const auto *M = dyn_cast<WasmObjectFile>(&O))
+  if (isa<WasmObjectFile>(&O))
     return Sec.getIndex();
 
   return cast<COFFObjectFile>(O).getSectionID(Sec);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73591.241027.patch
Type: text/x-patch
Size: 513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200129/f4e423e4/attachment-0001.bin>


More information about the llvm-commits mailing list