[PATCH] D73583: Handle non-absolute include dirs properly for both dwarf4 and dwarf5.
Sterling Augustine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 15:12:03 PST 2020
saugustine added a comment.
In D73583#1845756 <https://reviews.llvm.org/D73583#1845756>, @dblaikie wrote:
> Hmm - I would've thought there'd be some specific test coverage for this code already that it could be added to for DWARFv5 - but might be lost in the mists of time & this seems good.
The symbolize-directory test right next to it would be perfect (and, in fact, this code derives from that).
Except it deals with the directory entry zero, which is unallowed in dwarf4 and required in dwarf5, which makes sharing the source file between the two a bit of a pain. It's also testing something important, so needs to stay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73583/new/
https://reviews.llvm.org/D73583
More information about the llvm-commits
mailing list