[PATCH] D73383: Allow retrieving source files relative to the compilation directory.

Tue Jan 28 15:03:45 PST 2020

dblaikie added a comment.

In D73383#1845661 <https://reviews.llvm.org/D73383#1845661>, @saugustine wrote:

> In D73383#1842631 <https://reviews.llvm.org/D73383#1842631>, @dblaikie wrote:
>
> > > This revision also moves the absolute path logic out of the dwarf-4 only side of the conditional. I believe that was a mistake in an earlier patch, because there is nothing special about dwarf-4 vs dwarf-5 in this regard. Although there are some changes in where it is stored, they aren't relevant to whether it should be appended.
> >
> > That might be worthy of a separate patch & test case demonstrating the bug that's being fixed by moving that code out of the conditional.
>
>
> https://reviews.llvm.org/D73583
>
> The new test case fails without the accompanying fix.

Great, thanks! So once that's committed you can update this review with more test coverage in that test file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73383/new/

https://reviews.llvm.org/D73383