[PATCH] D73577: [compiler-rt] Build all alias in builtin as private external on Darwin

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

@steven_wu Please fix the description and commit message to address my questions. I don't think the original is clear enough.

> In D73577#1845560 <https://reviews.llvm.org/D73577#1845560>, @delcypher wrote:
> 
>> @steven_wu I'm having difficultly understanding the description.
>>
>> > For builtin compiler-rt, it is built with visibility hidden by default
>> >  to avoid the client exporting symbols from libclang static library.
>>
>> You mean to avoid exporting symbols from the libclang_rt to the client, right?
> 
> 
> yes.
> 
>> 
>> 
>>> The compiler option doesn't work on the alias which is created with inline assembly.
>> 
>> What is "The compiler option"?  You mean the default visibility compiler option, right?
> 
> -fvisibility=hidden
> 
>>> On Darwin platform, thoses aliases are exported by default if
>>>  they are reference by the client.
>>>  Fix the issue by adding ".private_extern" to all the aliases on Darwin
>> 
>> It is really not obvious what "the issue" is here? Are you saying that the "On Darwin platform, thoses aliases are exported by default if they are reference by the client." behaviour is what is happening right now and that this behaviour is incorrect?
> 
> Right now, the aliases are exported symbols by default from the client on darwin if you don't use an export list. That is not the correct behavior.

@steven_wu

The aliases are exported by the **client** because the object files from the compiler runtime get pulled into client binary at link time. Correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73577/new/

https://reviews.llvm.org/D73577