[PATCH] D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().

[Tim Shen via Phabricator via llvm-commits]

timshen marked 6 inline comments as done.
timshen added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:581
+                       .setAffineMaps({makeStridedLinearLayoutMap(
+                           strides, offset, b->getContext())})});
 }
----------------
ftynse wrote:
> Suggestion: since you are adding a helper class already, can you integrate `makeStidedLinearLayoutMap` into it directly as `MemRefTypeBuilder::setLinearLayoutMap`?
This is tricky, because it requires storing an AffineMap in the builder. However, StandarTypes.h doesn't see the full definition of AffineMap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73296/new/

https://reviews.llvm.org/D73296