[PATCH] D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 12:47:12 PST 2020


fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:170
+Optional<VFInfo> tryDemangleForVFABI(StringRef MangledName,
+                                     const Module *M = nullptr);
 
----------------
jdoerfert wrote:
> Any reason one would not pass `M` here? If not, I would remove the default and maybe even make it required (via reference).
Could do - that will require changing all unit tests to provide a module though... are you happy for me to do that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73286/new/

https://reviews.llvm.org/D73286





More information about the llvm-commits mailing list