[PATCH] D73228: [AsmPrinter][ELF] Define local aliases (.Lfoo$local) for GlobalObjects

Tue Jan 28 11:46:44 PST 2020

MaskRay marked 2 inline comments as done.
MaskRay added a subscriber: arsenm.
MaskRay added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/r600-constant-array-fixup.ll:4
 @arr = internal unnamed_addr addrspace(4) constant [4 x i32] [i32 4, i32 5, i32 6, i32 7], align 4

 ; CHECK: Relocations [
----------------
peter.smith wrote:
> As I understand it, this patch should just add local aliases for some known DSO local global symbols. This looks to have changed the relocation target and the value of arr. Intuitively I wouldn't have expected this from adding the aliases alone. There must be something I'm missing either in the patch, or this could be something to do with the AMDGPU backend. I'd be grateful if you could explain the difference?
After rebase, this change goes away.

It seemed an issue fixed by @arsenm in rG7dc49f77ee508b4152f9291c8e804e4eda3653d3 . It does look weird to me: adding a new symbol somehow alters relocations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73228/new/

https://reviews.llvm.org/D73228