[PATCH] D73420: [llvm] Ensure InlineCost-related fields are initialized
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 11:46:42 PST 2020
mtrofin marked an inline comment as done.
mtrofin added inline comments.
================
Comment at: llvm/include/llvm/Analysis/InlineCost.h:163
/// The default threshold to start with for a callee.
- int DefaultThreshold;
----------------
davidxl wrote:
> why is 0 a meaningful default value to start with?
My goal was to ensure the fields are initialized, to avoid nasty-to-debug uninitialized value bugs; so I picked 0 as the natural thing to initialize with. Happy to change to a different value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73420/new/
https://reviews.llvm.org/D73420
More information about the llvm-commits
mailing list