[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 11:34:45 PST 2020
jdoerfert added inline comments.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661
+ AfterIP = InsertPointTy(ForkBB, ForkBB->end());
+ }
----------------
Why do we need all of this? Can't we just *not do it* instead? This is code complexity that we should avoid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73285/new/
https://reviews.llvm.org/D73285
More information about the llvm-commits
mailing list