[PATCH] D73368: [FPEnv][AArch64] Add lowering of STRICT_FSETCC and STRICT_FSETCCS

[John Brawn via Phabricator via llvm-commits]

john.brawn marked an inline comment as done.
john.brawn added a comment.

In D73368#1844815 <https://reviews.llvm.org/D73368#1844815>, @craig.topper wrote:

> Probably need to make the FCMP and FCMPE ISD opcodes return true for isTargetStrictFPOpcode(). This done by making the opcodes larger than a specific constant. I’m on my phone so I don’t remember the exact name.


Hmm, I've made FCMP and FCMPE be used for both strict and non-strict SETCC but probably we only want isTargetStrictFPOpcode when it really is strict. I'll make a separate STRICT_FCMP and STRICT_FCMPE instead (and looking at the X86 and SystemZ targets that's how they've done it as well).



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:3562
 
-defm FCMPE : FPComparison<1, "fcmpe">;
 defm FCMP  : FPComparison<0, "fcmp", AArch64fcmp>;
----------------
craig.topper wrote:
> Do these need mayRaiseFPException?
I'd rather not touch anything relating to modelling exception behaviour at the MachineInstr level at the moment, as I'm currently just working on getting SelectionDAG to stop hitting asserts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73368/new/

https://reviews.llvm.org/D73368