[PATCH] D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2)

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop marked an inline comment as done.
russell.gallop added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1754
 template <class ELFT> void LinkerDriver::link(opt::InputArgList &args) {
+  llvm::TimeTraceScope timeScope("Link");
   // If a -hash-style option was not given, set to a default value,
----------------
anton-afanasyev wrote:
> MaskRay wrote:
> > I'd prefer `"LinkerDriver::link"`.
> Unified scope name like "Link" is good for grouping blocks by `chrome://tracing` app. Isn't it better to put `"LinkerDriver::link"` to `Details` field of `timeScope`? (though this field is usually used for _user_ source code names, but here it is unused).
I'll put "LinkerDriver::link" in the Details field.

Longer term it might be better to add another "args" field for function name to distinguish compiler source code names and user source code names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71060/new/

https://reviews.llvm.org/D71060