[PATCH] D73387: [MBP] Partial tail duplication into hot predecessors
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 09:44:33 PST 2020
davidxl added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:1156
+ // precise benefit analysis.
+ if (F->getFunction().hasProfileData())
+ return true;
----------------
should the benefit analysis be done here instead of just returning true?
================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:1818
+ // it out, just go round the loop again with BB as the chain end.
+ if (!BB->isSuccessor(BestSucc))
continue;
----------------
can you explain this new condition?
================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:3106
+
+void MachineBlockPlacement::findDuplicateCandidates(
+ SmallVectorImpl<MachineBasicBlock *> &Candidates,
----------------
Add some description (and examples) showing the algorithm/cost model used here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73387/new/
https://reviews.llvm.org/D73387
More information about the llvm-commits
mailing list