[PATCH] D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Analysis/Loads.cpp:487
+
       // If we have alias analysis and it says the store won't modify the loaded
       // value, ignore the store.
----------------
yamauchi wrote:
> xbolva00 wrote:
> > else {
> > 
> > 
> > ?
> Do you mean it'd be good to combine the two if statements?
> 
> ```
> if (!AA) {
>   // ...
>   if (AreNonOverlapSameBaseLoadAndStore(..))
>     continue;
> } else {
>   // ...
>   if (!isModSet(AA->getModRefInfo(SI, StrippedPtr, AccessSize)))
>     continue;
> }
> ```
Yes

(optional, if you like, do so)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71307/new/

https://reviews.llvm.org/D71307