[PATCH] D73526: [SafeStack][DebugInfo] Insert DW_OP_deref in correct location

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:758
+    MIB.addImm(0U);
+  else
+    MIB.addReg(0U, RegState::Debug);
----------------
This is surprising to me. Can you walk me through this as a sanity check to make sure this isn't papering over some other issue?

Both the before and after state should be equivalent:
Before your patch we emit a direct register location + DW_OP_deref afterwards we emit an indirect register location.

What am I missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73526/new/

https://reviews.llvm.org/D73526