[PATCH] D73554: [AIX] Don't use a zero fill with a second parameter

[David Tenty via Phabricator via llvm-commits]

daltenty marked 3 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1113
+    } else {
+      assert(isa<MCConstantExpr>(NumBytes) && "Cannot emit non-constant "
+                                               "expression lengths of "
----------------
Xiangling_L wrote:
> Is `.byte` a AIX only directive? If yes, maybe we should assert OS as AIX as well?
> And also is this assertion also apply to above `ZeroDirective`?
I would expect the `.byte` directive should be generally applicable (it's supported by GAS among others). The assertion is not, we could in theory emit a non-constant expression for the ZeroDirective and let the assembler do the calculation, but we cannot do this if we are just going to write out the bytes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73554/new/

https://reviews.llvm.org/D73554