[PATCH] D73460: [RDA][ARM] Move functionality into RDA

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a good and useful reshuffle to me



================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:120
 
+  bool hasLocalDefBefore(MachineInstr *MI, int PhysReg) const;
+
----------------
nit: missing comment/description


================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:188
+
+  /// Utility function for isSafeToMoveForwards/Backwards.
+  template<typename Iterator>
----------------
nit: if this is only a helper for isSafeToMoveForwards/Backwards, should this be a private function?


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:376
+// not define a register that is used by any instructions, after and including,
+// 'To'. These instructions also must not redefine any of Froms operands.
+template<typename Iterator>
----------------
nit: From's?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73460/new/

https://reviews.llvm.org/D73460