[PATCH] D73368: [FPEnv][AArch64] Add lowering of STRICT_FSETCC and STRICT_FSETCCS

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 07:54:29 PST 2020


john.brawn added a comment.

In D73368#1844483 <https://reviews.llvm.org/D73368#1844483>, @dmgreen wrote:

> If ISD::STRICT_FSETCCS has a chain, does AArch64ISD::FCMPE need a chain?


We should be doing that (and for FCMP as well), but it's currently there as a FIXME in line 5259. I'd thought that it would be tricky to do (it certainly is in AArch32 in D73194 <https://reviews.llvm.org/D73194>, due to some strange interaction with fmstat causing psr liveness to go wrong) but actually experimenting a bit it doesn't seem that hard. I'll have a new patch shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73368/new/

https://reviews.llvm.org/D73368





More information about the llvm-commits mailing list